fix(adapter): initialize klog into flags, to allow setting klog settings #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes update to klog v2 in f3a96b5, which requires klog.InitFlags(nil) to be called before.
|
@CatherineF-dev I think this small change would quickly resolve the issue #640. We're also seeing this in our prod environment. The 0.15 seemed to fix our |
|
cc @sophieliu15 |
|
Thanks! /lgtm |
|
Could you help bump adapter version as well? Similar to f072731 |
|
done! |
|
I did notice KEP-2845 this morning. I'm not fully understanding the consequence/goals. My main take-away was that the goal was to deprecate the requirement for klog in applications, while keeping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes update to klog v2 in f3a96b5, which requires klog.InitFlags(nil) to be called before.
Fixes #640 when used with
-v=1.