This repository was archived by the owner on Oct 27, 2022. It is now read-only.
add readme parsing tests #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaketramDurbha
requested review from
danielylee01,
dmahugh,
jsimonweb and
kurtisvg
SaketramDurbha
changed the title
kurtisvg
suggested changes
Aug 15, 2020
kurtisvg
changed the title
kurtisvg
approved these changes
Aug 17, 2020
Closed
kurtisvg
approved these changes
Aug 20, 2020
SaketramDurbha
requested review from
kurtisvg
and removed request for
grayside and
tritone
SaketramDurbha
force-pushed
the
readme-tests
branch
from
f9eea9b to
f053df7
Compare
added 7 commits
August 21, 2020 15:24
- add more test cases - make code more testable
- comment lifecycle.extractLifecycle - add comments to each test in readme_test.go - update mismatch error message format to readme_test.go - remove unnecessary equalError function in readme_test.go - other minor code clean up
SaketramDurbha
force-pushed
the
readme-tests
branch
from
f053df7 to
604a871
Compare
- TestParseReadme code fix - README -> Readme in code
tritone
reviewed
Aug 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #5 .
Will rebase and update once PR #22 is merged.