Migrate to CFT logging modules #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinPetkov
approved these changes
Oct 17, 2020
xingao267
reviewed
Oct 19, 2020
xingao267
reviewed
Oct 19, 2020
xingao267
reviewed
Oct 19, 2020
| expiration_days = 7*365 | ||
| retention_policy = { | ||
| is_locked = true | ||
| retention_period_days = 6 * 365 |
There was a problem hiding this comment.
what's the different between the retention_period_days here and expiration_days above? and why are they set to different values?
There was a problem hiding this comment.
Retention period does not actually do anything. It just forces the bucket to permanently have an expiry that is at least this amount. See https://cloud.google.com/storage/docs/bucket-lock. I also added a comment.
p.s. there seems to be an org policy we should probably set as well: https://cloud.google.com/storage/docs/org-policy-constraints#audit-logging. Do you want to look into that?
xingao267
reviewed
Oct 19, 2020
xingao267
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have upstreamed features from DPT into the CFT logging modules so they mostly match our feature set. They also have new features to set things like bucket locks which are useful for hipaa alignment.