Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels on resource level "google_compute_security_policy" #118

Open
Dipanshi293 opened this issue May 1, 2024 · 6 comments
Open

Add labels on resource level "google_compute_security_policy" #118

Dipanshi293 opened this issue May 1, 2024 · 6 comments
Labels
blocked Blocked by some other work enhancement New feature or request upstream Work required on Terraform core or provider

Comments

@Dipanshi293
Copy link

Dipanshi293 commented May 1, 2024

Hi Team,

We are calling terraform-google-cloud-armor module and resource "google_compute_security_policy", but there are no resource labels available in this resource. We also enforced hard-mandatory sentinel policies which check resource labels are attached to each and every resource.

main.tf

module "security_policy_default" {
  source                               = "git::https://github.com/GoogleCloudPlatform/terraform-google-cloud-armor.git?ref=v2.0.1"
  project_id                           = "project-1"
  name                                 = "sample-default-policy"
  description                          = "Test Cloud Armor security policy with preconfigured rules, security rules and custom rules"
  default_rule_action                  = "deny(403)"
  type                                 = "CLOUD_ARMOR"
  layer_7_ddos_defense_rule_visibility = "STANDARD"
  json_parsing                         = "STANDARD"
}
@imrannayer imrannayer added enhancement New feature or request upstream Work required on Terraform core or provider blocked Blocked by some other work labels May 1, 2024
@imrannayer
Copy link
Member

@Dipanshi293 feature is not available in provider. I have created feature request for the provider.

Blocked on hashicorp/terraform-provider-google#17993

@imrannayer
Copy link
Member

@Dipanshi293 is there any reason why you are using github url in source instead of terraform registry?

module "cloud-armor" {
  source  = "GoogleCloudPlatform/cloud-armor/google"
  version = "2.2.0"
 

@Dipanshi293
Copy link
Author

This is our module which calls Google Cloud Platform, and which is also available in the Terraform Registry.

Copy link

github-actions bot commented Jul 1, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jul 1, 2024
@imrannayer imrannayer removed the Stale label Jul 2, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Aug 31, 2024
@imrannayer imrannayer removed the Stale label Sep 1, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 31, 2024
@imrannayer imrannayer removed the Stale label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by some other work enhancement New feature or request upstream Work required on Terraform core or provider
Projects
None yet
Development

No branches or pull requests

2 participants