-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added advanced network ddos protection & network edge security policy sub-modules #113
Merged
imrannayer
merged 10 commits into
GoogleCloudPlatform:main
from
imrannayer:feat/adv-ddos-nlb-support
Apr 23, 2024
Merged
feat: added advanced network ddos protection & network edge security policy sub-modules #113
imrannayer
merged 10 commits into
GoogleCloudPlatform:main
from
imrannayer:feat/adv-ddos-nlb-support
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imrannayer
changed the title
feat: added advanced network ddos protection sub-module
feat: added advanced network ddos protection & network edge security sub-module (WIP)
Apr 19, 2024
imrannayer
changed the title
feat: added advanced network ddos protection & network edge security sub-module (WIP)
feat: added advanced network ddos protection & network edge security policy sub-module (WIP)
Apr 20, 2024
imrannayer
changed the title
feat: added advanced network ddos protection & network edge security policy sub-module (WIP)
feat: added advanced network ddos protection & network edge security policy sub-module
Apr 23, 2024
imrannayer
changed the title
feat: added advanced network ddos protection & network edge security policy sub-module
feat: added advanced network ddos protection & network edge security policy sub-modules
Apr 23, 2024
@bharathkkb plz review |
bharathkkb
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one question
examples/regional-adv-ddos-and-edge-security-policy-complete/provider.tf
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #24
fix #62
fix #107