Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Is the Managed Instance Group in the examples needed? #89

Open
idsvandermolen opened this issue Sep 18, 2018 · 1 comment
Open

Is the Managed Instance Group in the examples needed? #89

idsvandermolen opened this issue Sep 18, 2018 · 1 comment

Comments

@idsvandermolen
Copy link

A lot of the examples (ha-nat-gateway and multiple-nat-environments for example) use the nat-gateway-module and in addition to this use add their own managed-instance-group. For example at https://github.com/GoogleCloudPlatform/terraform-google-nat-gateway/blob/master/examples/ha-nat-gateway/main.tf#L81 .

However, the nat-gateway-module already uses a managed instance group to manage the nat gateway instances (see https://github.com/GoogleCloudPlatform/terraform-google-nat-gateway/blob/master/main.tf#L47).

Unless I'm mistaken I think the managed instances groups in the examples are not used at all and could be removed.

@idsvandermolen
Copy link
Author

It looks like these MIGs are used to manage the example instances and so are not directly used in the NAT gateway setup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant