DynamicView zoom-fit behavior breaks when main window is maximized

[Gooichand]

Issue Summary

Zoom-fit scale not updated correctly on window resize / maximize

Description

In DynamicView.resizeEvent, there is a FIXME comment noting: "Se la finestra viene massimizzata, il valore di fit_scale non si aggiorna" (when the window is maximized, fit_scale is not updated).
The current logic calls zoom_fit() only when the existing transform scale is less than or equal to fit_scale; otherwise, it just emits notify_change().
This means that after maximizing or significantly resizing the window, the fit-to-window scaling can become out-of-sync, causing suboptimal zoom behavior.

Steps to Reproduce

1. Open any tool that uses ImageViewer / DynamicView (e.g., Original Image).
2. Load an image and double-click to fit it.
3. Maximize or resize the main window to a much larger size.
4. Observe that the fitted image may no longer optimally fill the viewport due to stale fit_scale.

Expected Result

When the window is maximized or resized, the fit-scale should be recomputed so that "Fit" always behaves consistently with the new window dimensions.

Actual Result

fit_scale can remain based on the previous size, leading to incorrect zoom levels after maximizing; the code itself flags this as a known issue via the FIXME comment.

Affected Files

• gui/viewer.py

Suggested Fix

Recompute fit_scale on resize (e.g., always call zoom_fit() when in fit mode), or track a "fit mode" state and recalculate scale whenever the viewport changes significantly. Remove the FIXME once behavior is corrected.

[Hasini31]

Hi, I would like to work on this issue.
I’m planning to fix the fit-scale update on resize by tracking a fit-mode state and recalculating the scale when the viewport changes.

[Gooichand]

🙌 Thanks for your interest in working on this issue! @Hasini31

We'd be happy to assign this issue to you soon. Before you start, please make sure to:

📝 Pre-Assignment Requirements:

📖 Follow the guidelines: https://github.com/Gooichand/blockchain-evidence?tab=contributing-ov-file
📋 Follow proper order and workflow and wait until the issue assign To you
💡 Comment your plan of action to resolve this issue (required)
👤 New Contribute make sure you fill this https://forms.cloud.microsoft/r/0VjHehyNaw

🎯 Next Steps:

Based on your plan of action, the issue will be assigned to you. If you run into any blockers, feel free to ask questions or request guidance.

Collaboration is always welcome, and we appreciate your contribution to improving this project! 🚀

~ Team Look-DGC 🔐

[Hasini31]

This is my plan of action:

1.Review the existing Dynamic View. resize Event implementation and reproduce the fit-scale issue during window resize or maximize.
2.Introduce a dedicated “fit mode” state to explicitly track when the viewer is in fit-to-window mode.
3.Update the resize handling logic to recompute the fit scale only when fit mode is active, while preserving manual zoom behavior.
4.Remove the existing FIXME comment after verifying the issue is resolved.
5.Test the updated behavior across multiple resize scenarios to ensure consistent and correct zoom functionality.
6.Submit a focused pull request with a clear description and reference to this issue.
7. screenshot or short video of working

[Gooichand]

@Hasini31 go ahead

[Hasini31]

Hi ,

I’ve made some updates to viewer.py while working on the zoom-fit resize issue and wanted to confirm the behavior before raising a PR.

🔗 Current behavior (after changes):
https://github.com/user-attachments/assets/21f78876-2ff7-470b-a2ce-0868730d767b

🔗 Previous behavior (before changes):
https://github.com/user-attachments/assets/09a1f204-8b52-49a5-bc84-159d74f040c2

The updated logic recalculates the fit scale on resize and reapplies Fit only when the view was already in fit-to-window mode, fixing the stale fit_scale issue while preserving manual zoom.

Please let me know if this behavior looks correct. If so, I’ll proceed with the PR.

Thanks!

[Gooichand]

@Hasini31 rise the pr it perfect

[Hasini31]

i raised the PR

[Gooichand]

📢 Important: OSCG-26 Communication Update

Body:
All contributors working on the DGC project, please note:

Nexfellow is now our primary communication platform for OSCG-26.

👉 Important announcement - Please like and follow:
https://www.nexfellow.com/post/698eac9c636efcd987385b54

This post contains critical project updates and information.

Thank you for your contributions! 🙏