Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several menu options are broken in latest SM64DSe release #52

Open
icup321 opened this issue Feb 19, 2024 · 2 comments
Open

Several menu options are broken in latest SM64DSe release #52

icup321 opened this issue Feb 19, 2024 · 2 comments

Comments

@icup321
Copy link

icup321 commented Feb 19, 2024

  1. The Additional Patches menu doesn't work due to a missing AdditonalPatches.xml file.
  2. Decompress Overlays Within Game now causes an error saying that the ROM is being used by a different process and also corrupts the entire ROM.
  3. Toggle Suitability for NSMBe ASM Patching does nothing but break compatibility with MelonDS and several ROM flashcarts and should honestly be removed as NSMBe no longer requires patched ROMs to apply ASM patches anyway.

All of these broken options should really be either fixed or removed to prevent new users from accidentally corrupting their ROMs.

@axel7083
Copy link
Collaborator

axel7083 commented Feb 22, 2024

  1. The Additional Patches menu doesn't work due to a missing AdditonalPatches.xml file.
  1. Decompress Overlays Within Game now causes an error saying that the ROM is being used by a different process and also corrupts the entire ROM.

I cannot reproduce, I am able to click on decompress overlay, can you provide steps reproducing the error ?

  1. Toggle Suitability for NSMBe ASM Patching does nothing but break compatibility with MelonDS and several ROM flashcarts and should honestly be removed as NSMBe no longer requires patched ROMs to apply ASM patches anyway.

All of these broken options should really be either fixed or removed to prevent new users from accidentally corrupting their ROMs.

@pants64DS do you also think we should remove the following option ?
image

@pants64DS
Copy link
Contributor

@pants64DS do you also think we should remove the following option ?
image

Nope. It's true that NSMBe doesn't need the vanilla rom to be patched before inserting code (as long as you decompress the ARM9 binary first), that option is still needed for roms that have been patched with SM64DSe, otherwise it won't work.

@icup321 I've used that "toggle suitability with NSMBe ASM patching" option for all the rom hacks I've worked on and it never caused any compatibility issues with any emulator or flashcard. What version of NSMBe did you use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants