Clean up DependencyMap #11
Comments
djmitche
added a commit
to djmitche/taskchampion
that referenced
this issue
Jan 1, 2025
Using Rc saves some atomic operations, at the cost of the result being usable only from one thread. But lots of things are multi-threaded, including Python, which causes issues trying to [wrap this type](GothenburgBitFactory/taskchampion-py#11). This isn't performance-critical code, so let's just us Arc. This is a breaking change to the return type of `Replica::dependency_map`. This also adds a `Clone` derive to the type, just in case someone wants the data without sharing.
djmitche
added a commit
to djmitche/taskchampion-py
that referenced
this issue
Jan 1, 2025
The existing `Rc::into_inner` trick _never_ works, because the Replica always holds one count of the `Rc` for itself, and returns a second count -- so the reference count is always two. And, Rc::unwrap_or_clone` doesn't work because `DependencyMap` can't be cloned. This is a giant hack, as explained by comments inline. It's also temporary, until GothenburgBitFactory/taskchampion#514 is released. I'll leave GothenburgBitFactory#11 open until that time. Alternatives: - Parse the `std::fmt::Debug` output into a local data structure (!) - Just remove `Replica::dependency_map` from the API until taskchampion#514 is avaliable.
djmitche
added a commit
to GothenburgBitFactory/taskchampion
that referenced
this issue
Jan 1, 2025
Using Rc saves some atomic operations, at the cost of the result being usable only from one thread. But lots of things are multi-threaded, including Python, which causes issues trying to [wrap this type](GothenburgBitFactory/taskchampion-py#11). This isn't performance-critical code, so let's just us Arc. This is a breaking change to the return type of `Replica::dependency_map`. This also adds a `Clone` derive to the type, just in case someone wants the data without sharing.
|
Now waiting for GothenburgBitFactory/taskchampion#514, which will be in TaskChampion 2.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are some TODOs in
dependency_map.rsand inReplica::dependency_map. I think most are a no-op, but the error handling could be better.The text was updated successfully, but these errors were encountered: