Context is not respected by modify command.

[rubieking]

• What command(s) did you run?

## Here's the exact set of commands I ran on an empty task warrior instance running 3.2.0 to simulate the issue.
task add main1
task add main2
task context define personal "project:Personal"
task context define work "project:Work"
task context personal
task add p1
task add p2
task context work
task add w1
task add w2
task status:pending modify +testtag
task context none
task list

## Here's the actual output
$ task list

ID Age   Project  Tags    Description Urg
 1 53s            testtag main1        0.8
 2 52s            testtag main2        0.8
 3 43s   Personal testtag p1           1.8
 4 42s   Personal testtag p2           1.8
 5 40s   Work     testtag w1           1.8
 6 39s   Work     testtag w2           1.8

6 tasks

• What did you expect to happen? What actually happened?
  Modify should respect the context that is set and only update the appropriate items. However, it updates everything. Note that task list works as expected.
• Paste the output of the task diag command.

$ task diag

task 3.2.0
   Platform: Linux

Compiler
    Version: 13.3.0
       Caps: +stdc +stdc_hosted +LP64 +c8 +i32 +l64 +vp64 +time_t64
 Compliance: C++17

Build Features
     Commit: 7a092bea0
      CMake: 3.28.3
    libuuid: libuuid + uuid_unparse_lower
 Build type: Release

Configuration
       File: /home/ubuntu/.taskrc (found), 950 bytes, mode 100664
       Data: /home/ubuntu/.task (found), dir, mode 40775
         GC: Enabled
Hooks
     System: Enabled
   Location: /home/ubuntu/.task/hooks
             (-none-)

Tests
   Terminal: 324x27
 Broken ref: Scanned 6 tasks for broken references:
             No broken references found

[rubieking]

I've also identified the fix and it's straightforward. Tested the fix as well. I'd have to look into tests, but happy to take a stab at making a PR assuming the current behavior is not intentional.

[djmitche]

PRs are great!

[rubieking]

Thanks, will take a look. Also to add, this seems to be the only one that needs to be fixed. Rest seem to be accurate already.

[djmitche]

I wonder if this is related ti #2917?

[rubieking]

I looked into it a little bit and I think the issues are different. Primarily, the issue here is trivial and just needs a change in the CmdModify.cpp to update the field _uses_context to true.

#2917 doesn't seem to be the same. Based on my tests, the filtering does work but there seems to be some special cases that need to be looked at in detail. I'll document my findings in a comment in that ticket.

I'm also just about to send out a PR for this one. It contains just the trivial boolean change.

[rubieking]

Sent out this PR but it seems to have a test/coverage failure. Somehow didn't have any failure on my box when I tried to run tests. I assume I did not run the correct tests.

Will try to look into this and fix tests.