Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reiterate on streaming extractor APIs #46

Open
Gottox opened this issue Aug 20, 2023 · 0 comments
Open

reiterate on streaming extractor APIs #46

Gottox opened this issue Aug 20, 2023 · 0 comments
Milestone

Comments

@Gottox
Copy link
Owner

Gottox commented Aug 20, 2023

Is your feature request related to a problem? Please describe.

One of the pieces where libsqsh isn't zero-copy is the uncompression of non-continious blocks. While this is an edge case it could end up in situation where up to 1 MiB get copied just to uncompress them afterwards and unnecessarily cache them.

Describe the solution you'd like

The better solution is to write the partial blocks to the extractor and let it handle internal state. This would reduce the amount of (large) copies inside libsqsh.

Describe alternatives you've considered

None

Additional context

The issue is that the implementation of extractors must be capable to always process incoming data completely.

@Gottox Gottox added this to the v1.x milestone Aug 20, 2023
@Gottox Gottox changed the title reiterate on streaming APIs reiterate on streaming extractor APIs Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant