-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to build on macos #77
Comments
MacOS again... 🤬 |
Local build output➜ libsqsh git:(origin/fix/macos-build) meson test -C /tmp/build -t 5 ninja: Entering directory `/private/tmp/build' [169/169] Linking target test/read-chunk 1/38 archive/compression_options.c OK 0.17s 2/38 easy/directory.c OK 0.33s 3/38 easy/file.c OK 0.49s 4/38 cpp-test.cpp OK 0.64s 5/38 directory/directory_iterator.c OK 0.81s 6/38 extract/extract.c OK 0.98s 7/38 extract/extract_manager.c OK 1.10s 8/38 file/file_iterator.c OK 1.26s 9/38 file/file_reader.c OK 1.38s 10/38 fuzzer_repro.c OK 1.57s 11/38 include_tests/sqsh_archive.c OK 1.55s 12/38 include_tests/sqsh_easy.c OK 1.53s 13/38 include_tests/sqsh_common.c OK 1.52s 14/38 include_tests/sqsh_directory.c OK 1.57s 15/38 include_tests/sqsh_error.c OK 1.56s 16/38 include_tests/sqsh_file.c OK 1.56s 17/38 include_tests/sqsh_mapper.c OK 1.58s 18/38 include_tests/sqsh_table.c OK 1.59s 19/38 include_tests/sqsh_tree.c OK 1.61s 20/38 include_tests/sqsh_xattr.c OK 1.57s 21/38 file/file.c OK 1.60s 22/38 integration.c OK 1.67s 23/38 mapper/map_iterator.c OK 1.59s 24/38 mapper/map_reader.c OK 1.55s 25/38 metablock/metablock_iterator.c OK 1.54s 26/38 metablock/metablock_reader.c OK 1.54s 27/38 nasty.c OK 1.51s 28/38 reader/reader.c OK 1.49s 29/38 tree/walker.c OK 1.53s 30/38 xattr/xattr_iterator.c OK 1.47s 31/38 tools/unpack/pathtraversal/pathtraversal.sh OK 2.07s 32/38 tools/unpack/repack.sh OK 2.39s 33/38 tools/read-chunk/tail.sh OK 2.69s 34/38 selftest.sh OK 4.90s 35/38 tools/cat/large-file-compressed.sh OK 6.56s 36/38 tools/cat/large-file-uncompressed.sh OK 6.68s 37/38 tools/fs/large-file.sh (sqshfs2) FAIL 52.20s exit status 1 >>> SOURCE_ROOT=/private/tmp/libsqsh SQSH_CAT=/private/tmp/build/tools/sqsh-cat SQSH_UNPACK=/private/tmp/build/tools/sqsh-unpack MALLOC_PERTURB_=120 BUILD_DIR=/private/tmp/build/test SQSH_LS=/private/tmp/build/tools/sqsh-ls SQSHFS=/private/tmp/build/tools/sqshfs2 MKSQUASHFS=/opt/homebrew/bin/mksquashfs READ_CHUNK=/private/tmp/build/test/read-chunk /private/tmp/libsqsh/test/tools/fs/large-file.sh
|
Automated testing of fuse filesystems on macos seems to be hard nowadays: |
Tests passed for 09d5519 Local build output➜ libsqsh git:(origin/fix/macos-build) meson test -C /tmp/build -t 5 ninja: Entering directory `/private/tmp/build' [165/165] Linking target tools/sqsh-cat 1/36 archive/compression_options.c OK 0.16s 2/36 easy/directory.c OK 0.32s 3/36 easy/file.c OK 0.46s 4/36 cpp-test.cpp OK 0.60s 5/36 directory/directory_iterator.c OK 0.75s 6/36 extract/extract.c OK 0.90s 7/36 extract/extract_manager.c OK 1.04s 8/36 file/file_iterator.c OK 1.19s 9/36 file/file_reader.c OK 1.33s 10/36 fuzzer_repro.c OK 1.50s 11/36 include_tests/sqsh_archive.c OK 1.49s 12/36 include_tests/sqsh_easy.c OK 1.47s 13/36 include_tests/sqsh_common.c OK 1.48s 14/36 include_tests/sqsh_directory.c OK 1.47s 15/36 include_tests/sqsh_error.c OK 1.47s 16/36 include_tests/sqsh_file.c OK 1.47s 17/36 include_tests/sqsh_mapper.c OK 1.48s 18/36 include_tests/sqsh_table.c OK 1.47s 19/36 include_tests/sqsh_tree.c OK 1.48s 20/36 include_tests/sqsh_xattr.c OK 1.47s 21/36 file/file.c OK 1.49s 22/36 integration.c OK 1.53s 23/36 mapper/map_iterator.c OK 1.48s 24/36 mapper/map_reader.c OK 1.48s 25/36 metablock/metablock_iterator.c OK 1.49s 26/36 metablock/metablock_reader.c OK 1.52s 27/36 nasty.c OK 1.74s 28/36 reader/reader.c OK 1.75s 29/36 tree/walker.c OK 1.77s 30/36 xattr/xattr_iterator.c OK 1.75s 31/36 tools/unpack/pathtraversal/pathtraversal.sh OK 2.04s 32/36 tools/unpack/repack.sh OK 2.38s 33/36 tools/read-chunk/tail.sh OK 2.76s 34/36 selftest.sh OK 4.67s 35/36 tools/cat/large-file-compressed.sh OK 6.84s 36/36 tools/cat/large-file-uncompressed.sh OK 6.83s |
According to [1] macfuse is hard to be used inside of github actions. This commit modifies the test suite to not test sqshfs2 if the host system is darwin. [1] #77 (comment)
According to [1] macfuse is hard to be used inside of github actions. This commit modifies the test suite to not test sqshfs2 if the host system is darwin. [1] #77 (comment)
fixed in #78 |
Thank you! |
Describe the bug
Build fails on macos because
#include <endian.h>
To Reproduce
Full output
Expected behavior
Build successful
Platform (please complete the following information):
uname -a
output:Additional context
I was able to hackily limp along by removing the includes, and defining no-ops for
le32toh
(and the like), and it seemed to succeed, so it seems like it's close to supporting macos.The text was updated successfully, but these errors were encountered: