Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Spline tool draw a polylines with a Path -> Spline from Points node setup #2184

Open
2 of 4 tasks
Keavon opened this issue Jan 10, 2025 · 4 comments · Fixed by #2200 or #2203
Open
2 of 4 tasks

Make the Spline tool draw a polylines with a Path -> Spline from Points node setup #2184

Keavon opened this issue Jan 10, 2025 · 4 comments · Fixed by #2200 or #2203
Assignees
Labels
Good First Issue Good for newcomers

Comments

@Keavon
Copy link
Member

Keavon commented Jan 10, 2025

  1. Make the Spline tool visualize the endpoints of each spline path just like the Freehand tool does (even if there are multiple spline paths because the Path node has multiple subpaths)
  2. Allow clicking on the endpoints of a spline (on either end), when not drawing, to begin drawing a continuation of the spline
  3. Allow clicking the start point while drawing spline segments to add a segment which closes the path given to the Spline from Points node
  4. Allow holding Shift to begin drawing a new spline subpath in the same layer, instead of making it add a new layer (just like the equivalent functionality with the Pen tool)
  • Part 3
  1. Create an upgrade script to transform a single existing "Spline" node, in the graph of any existing documents people have today, into a Path -> Spline from Points node pair with the point data transferred over to the Path node's geometry

  2. Delete the "Spline" node

  3. Rename the "Spline from Points" node to just "Spline"

  4. Create an upgrade script to rename the "Spline from Points" node in existing documents to "Spline"

    Search the project for "document upgrade code" and you'll find all the comments relating to the upgrading scripts. The ones in portfolio_message_handler.rs, within the handler for the PortfolioMessage::OpenDocumentFileWithId message, are most relevant to read and that's likely where you'll be adding most or all the upgrading code to.

@Keavon Keavon added Feature Good First Issue Good for newcomers labels Jan 10, 2025
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Jan 10, 2025
@kliwongan
Copy link

Can I take this issue as my first issue?

@Keavon
Copy link
Member Author

Keavon commented Jan 14, 2025

@kliwongan this is currently being worked on by @indierusty (here's the Discord thread). If there isn't a viable PR opened within a week, feel free to ask again if it's available then.

@Keavon
Copy link
Member Author

Keavon commented Jan 15, 2025

@kliwongan I ended up adding a new part to this issue, so now it's a three-parter. Feel free to work on part 3, which isn't blocked by the previous two parts, if you would like. If you plan to work on it, please let me know when you'll be beginning.

@indierusty
Copy link
Contributor

Implemented Part 1 i.e. make spline tool to use Path and Spline from Points node instead of just Spline node to make spline tool further non-destructive in #2200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment