Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build up our test CI to protect the code #274

Open
dadiorchen opened this issue Jan 18, 2023 · 1 comment
Open

Build up our test CI to protect the code #274

dadiorchen opened this issue Jan 18, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@dadiorchen
Copy link
Contributor

  1. we don't run test in CI to check the code
  2. The test is incomplete, and inappropriate, we just run e2e test to connect to the real database, downside of this is that we have to rely on outside truth, database here. So we need change to integration test + unit test to cover at lease the main part of the API

Maybe this issue is too big, could consider a project and split to smaller pieces of tasks.


Some hints:

  • Please read our readme for more information/guide/tutorial.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.
@dadiorchen dadiorchen added the good first issue Good for newcomers label Jan 18, 2023
@dadiorchen
Copy link
Contributor Author

This is more about development to build test for the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant