Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The husky can not check the commit message #352

Open
dadiorchen opened this issue Jul 31, 2023 · 2 comments
Open

The husky can not check the commit message #352

dadiorchen opened this issue Jul 31, 2023 · 2 comments
Assignees
Labels
bug Something isn't working devops husky

Comments

@dadiorchen
Copy link
Contributor

dadiorchen commented Jul 31, 2023

In this commit/pr, the commit message is wrong: ``fix:organization_filter for growerV2, there should be space after fix:`, husky issupposed to deny that commit on the `git commit -m "fix:xxx"` but it doesn't, we need to find out the way to force husky checking on every dev's computer.


Some hints:

We want to use Husky to force a conventional commit(https://gist.github.com/qoomon/5dfcdf8eec66a051ecd85625518cfd13) check on all commits. This is implemented in other microservices and can be used as a reference,

  • Please read our readme for more information/guide/tutorial.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.
@dadiorchen dadiorchen added bug Something isn't working devops husky labels Jul 31, 2023
@brena-odwyer
Copy link

Hi, I will be taking the issue

@dadiorchen
Copy link
Contributor Author

Great, I have assigned it to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops husky
Projects
None yet
Development

No branches or pull requests

2 participants