Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page layout disorder when use the parameter query: ?embed=true #1674

Open
dadiorchen opened this issue Jul 4, 2023 · 6 comments · May be fixed by #1682
Open

Page layout disorder when use the parameter query: ?embed=true #1674

dadiorchen opened this issue Jul 4, 2023 · 6 comments · May be fixed by #1682
Labels
bug Something isn't working good first issue Good for newcomers nextjs react

Comments

@dadiorchen
Copy link
Collaborator

https://map.treetracker.org/organizations/178?bounds=-253.12500000000003,-80.11856387883782,253.12500000000003,80.11856387883782&embed=true

When visiting this url, as shown below, there is a non-embed layout showing up and disappearing quickly before the correct layout show up.

Some hints:

  • Please read our readme for more information/guide/tutorial.
  • For design guidelines checkout our Figma design.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.
@dadiorchen dadiorchen added bug Something isn't working good first issue Good for newcomers react nextjs labels Jul 4, 2023
@Ewan88 Ewan88 linked a pull request Jul 5, 2023 that will close this issue
Open
6 tasks
@Ewan88
Copy link
Contributor

Ewan88 commented Jul 5, 2023

I could not reproduce this issue locally however I did notice a couple of other issues around this - the above mentioned pull request addresses those issues.

I also noticed some behaviour where the embed params would be removed when the user pans the map. It might be worth investigating that issue separately - possibly along with #658

I am curious if it's worthwhile to add integration tests for the embed behaviour? My fears are that such tests could be extremely flaky.

@dadiorchen
Copy link
Collaborator Author

The missing params might be solved by this: #1661

Yea, I agree, the integration test costs maintaness, let's just do it when necessary.

@Ewan88 if you are interested to join our community, please leave your email, I would be happy to invite you

@dadiorchen
Copy link
Collaborator Author

Oh, sorry I forgot to paste the video: https://dadior.s3.ap-northeast-1.amazonaws.com/Screen%20Recording%202023-07-06%20at%203.34.00%20PM.mp4

Take a look the video, when reload the page, a un-embed layout flash in and out.

@vijayasree19
Copy link

If this issue is open i can work on this

@Ewan88
Copy link
Contributor

Ewan88 commented Aug 22, 2023 via email

@dadiorchen
Copy link
Collaborator Author

@vijayasree19 yes, please go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers nextjs react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix page layout embedded Ewan88/treetracker-web-map-client
3 participants
@dadiorchen @Ewan88 @vijayasree19