Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable detection within AF Elements query broken in editor mode #142

Closed
aballinEH2 opened this issue Jan 28, 2024 · 4 comments
Closed
Labels
Milestone

Comments

@aballinEH2
Copy link

When I was running Grafana 9.4.3 using the OSIsoft-PI plugin version 2.0.0 (or possibly 2.1.1), there was a bug with including Grafana dashboard variables as part of the AF path query. Screen shot below is from a dashboard containing location and system variables.
image
The segment Unit${system} is white, indicating that the presence of the variable isn't detected, and I can't further navigate down the asset tree. This is confirmed when I switch to raw query mode where 'Unit${system}' is replaced with 'undefined'.
image
Upgrading the plugin to version 4.2.0 fixed this issue (the segment would show up in blue text and I could further navigate in the asset tree), but upgrading to Grafana 10.2.3 seems to have broken the fix. Any chance this can be remedied again? Thanks!

@alexl04
Copy link

alexl04 commented Mar 19, 2024

In addition, could it be that there is a limit to the amount of AF Attributes shown/received from the API? In below example we have 6000+ attributes. If I try to find some attribute starting with the T (after CP1_) by typing "CP1_T" we do not receive any attributes at all. If I type "CP1_A" we do receive all attributes that contain that string. By scrolling through the asset tree we can see that it stops at "G". So could it be that the AF attribute query is send once instead of every time we enter some search?

image

@coderReview
Copy link
Collaborator

Fixed in #150

@coderReview coderReview added this to the Version 5.0.0 milestone Apr 5, 2024
@alexl04
Copy link

alexl04 commented May 21, 2024

Fixed in #150

Tested with grafana 11 and plugin v5 beta > cannot confirm that it is fixed. I experience the same issue as described above.

@pvmagacho-nde
Copy link

For v5.0.0 I am increasing the max attributes count to 10000. I next versions I can check if we can improve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants