Skip to content

feat[next-dace]: Try mixed-GTIR lowering to SDFG #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
edopao wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat[next-dace]: Try mixed-GTIR lowering to SDFG #2467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/gt4py/next/iterator/transforms/pass_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ def apply_common_transforms(
unroll_reduce=False,
common_subexpression_elimination=True,
force_inline_lambda_args=False,
fuse_maps=True,
transform_concat_where_to_as_fieldop=True,
#: A dictionary mapping axes names to their length. See :func:`infer_domain.infer_expr` for
#: more details.
symbolic_domain_sizes: Optional[dict[str, str]] = None,
Expand Down Expand Up @@ -92,7 +94,8 @@ def apply_common_transforms(
ir = prune_empty_concat_where.prune_empty_concat_where(ir)
ir = remove_broadcast.RemoveBroadcast.apply(ir)

ir = concat_where.transform_to_as_fieldop(ir)
if transform_concat_where_to_as_fieldop:
ir = concat_where.transform_to_as_fieldop(ir)

for _ in range(10):
inlined = ir
Expand Down Expand Up @@ -142,7 +145,8 @@ def apply_common_transforms(

ir = NormalizeShifts().visit(ir)

ir = FuseMaps(uids=uids).visit(ir)
if fuse_maps:
ir = FuseMaps(uids=uids).visit(ir)
ir = CollapseListGet().visit(ir)

if unroll_reduce:
Expand All @@ -164,6 +168,12 @@ def apply_common_transforms(
ir, opcount_preserving=True, force_inline_lambda_args=force_inline_lambda_args
)

ir = infer_domain.infer_program(
ir,
offset_provider=offset_provider,
symbolic_domain_sizes=symbolic_domain_sizes,
)

assert isinstance(ir, itir.Program)
return ir

Expand Down
7 changes: 6 additions & 1 deletion src/gt4py/next/program_processors/runners/dace/workflow/translation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,12 @@ def _generate_sdfg_without_configuring_dace(
column_axis: Optional[common.Dimension],
) -> dace.SDFG:
if not self.disable_itir_transforms:
ir = itir_transforms.apply_fieldview_transforms(ir, offset_provider=offset_provider)
ir = itir_transforms.apply_common_transforms(
ir,
offset_provider=offset_provider,
fuse_maps=False,
transform_concat_where_to_as_fieldop=False,
)
offset_provider_type = common.offset_provider_to_type(offset_provider)
on_gpu = self.device_type != core_defs.DeviceType.CPU

Expand Down
Loading