Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility for implementing a renderer? #24

Open
AlexEne opened this issue Oct 19, 2020 · 1 comment
Open

Add possibility for implementing a renderer? #24

AlexEne opened this issue Oct 19, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AlexEne
Copy link
Contributor

AlexEne commented Oct 19, 2020

Hello,

This crate looks super cool so thanks for that.
What do you think about adding the possibility for users of this crate to implement their own Renderer?

One use-case would be people that don't use glium/webgpu.rs (I use gl for my game). I woud build my own GLRenderer, but as it is now, the Renderer trait is impossible to implement as it depends on things that are private like TextureHandle, FontHandle, FontSource, etc.

Thanks,
Alex

@AlexEne AlexEne changed the title Add possibility for implementing a renderer Add possibility for implementing a renderer? Oct 19, 2020
@Grokmoo Grokmoo added enhancement New feature or request good first issue Good for newcomers labels Oct 20, 2020
@Grokmoo
Copy link
Owner

Grokmoo commented Oct 20, 2020

Ideally I think the work creating a new Renderer would be included in crate. That way others could also use your work. If you did the bulk of the work actually doing the implementation I would be happy to handle updating docs, feature flags, etc.

However, I also don't think there is anything in particular preventing everything being used in Renderer from being made public. I guess this would mostly be a matter of adding docs. I would want to make it clear which types are only of interest for this sort of work vs which are of use for someone just using the crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants