This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
ConnectionError not handled correctly if there are no connections in the pool #453
Comments
FranGM
pushed a commit
to FranGM/redis-py-cluster
that referenced
this issue
Jul 19, 2021
This is another case of Grokzen#453 There are cases in which we can get a `BaseException` before we have established a connection, which means that attempting to disconnect from it will result in an unhandled exception.
|
I don't know if I can reopen issues but there's another instance of this issue with a fix here: #472 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi there!
Recently we ran into an issue where it seems like we were not handling a
ConnectionErrorcorrectly and tried to callconnection.disconnect()(see here ) whenconnectionhad aNonevalue, which results in an unhandled exception being raised.Seems like if you're using
ClusterBlockingConnectionPool, and time out before a connection is available aConnectionErrorwill get raised, which gets mishandled in this case. The rest of the error handling seems correct to me, so I'm going to submit a PR that just checks thatconnectionis notNonebefore attempting to disconnect, and I'll be happy to add any other stuff that you think might be missing.The text was updated successfully, but these errors were encountered: