Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Parsing of redis url:s with database in it fails #456

Open
Grokzen opened this issue May 12, 2021 · 0 comments
Open

Parsing of redis url:s with database in it fails #456

Grokzen opened this issue May 12, 2021 · 0 comments
Labels
Accepted Accepted bug or enhancement Accepting PR type: bug

Comments

@Grokzen
Copy link
Owner

Grokzen commented May 12, 2021

If you pass in "redis://redis:6379/2" with a database parameter into the parse_url version in this lib it will fail out as the DB will be set implicitly and that will propegate automatically up to redis-py connection pool that will attempt to send SELECT command to redis when connection runs on_connect method and SELECT command is not supported when running a cluster node.

The proposed solution is to either strip out DB from the url before parsing it, or to hard fail when this is processed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accepted Accepted bug or enhancement Accepting PR type: bug
Projects
None yet
Development

No branches or pull requests

1 participant