Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IOBuffer in _inflate() #22

Closed
wants to merge 1 commit into from
Closed

Use IOBuffer in _inflate() #22

wants to merge 1 commit into from

Conversation

kimikage
Copy link
Contributor

@kimikage kimikage commented May 30, 2024

I am not sure whether it is worth merging this PR, as I do not know how to use "test_performance.jl" properly.
This is just a conceptual example of what I see with issue #19.

In other words, I was interested in proper handling of the types, and I no longer care much for the performance improvements in this package.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.37%. Comparing base (f16eec8) to head (0533ce8).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   99.35%   99.37%   +0.01%     
==========================================
  Files           1        1              
  Lines         468      482      +14     
==========================================
+ Hits          465      479      +14     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GunnarFarneback
Copy link
Owner

The usual result is that you run test_performance.jl for a good while without and with some change, then you get back results which are inconclusive with some cases getting faster and some getting slower, which is what I'm seeing here as well.

I'm also not too enthusiastic about optimizing this code, but mostly because I know that if you port libdeflate to Julia, you get something which is not only faster than this code, but also faster than libz.

@GunnarFarneback
Copy link
Owner

Incidentally #9 also targets append! and would have solved half of the 32-bit issue.

@kimikage kimikage closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants