Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mess with the code until tests pass and it's faster #26

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LilithHafner
Copy link
Contributor

trades technical debt for performance.
probably not a good idea to merge now.
blind
these changes were based mostly on benchmarks and tests and not on understanding semantics and performance characteristics. It's quite plausible it adds bugs or performance holes.

trades technical debt for performance
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.38%. Comparing base (f16eec8) to head (7e82642).
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   99.35%   99.38%   +0.02%     
==========================================
  Files           1        1              
  Lines         468      484      +16     
==========================================
+ Hits          465      481      +16     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LilithHafner
Copy link
Contributor Author

master In Memory
incompressible huffman runlength graph
small deflate 2.0 2.9 3.7 2.3
zlib 2.9 2.8 4.0 2.4
gzip 4.1 3.0 3.5 2.5
medium deflate 1.6 3.2 2.7 3.2
zlib 3.7 3.5 2.9 3.2
gzip 5.0 3.5 3.3 3.5
large deflate 4.8 3.4 2.6 3.3
zlib 3.7 3.4 2.6 3.4
gzip 5.0 3.7 3.2 3.6
master Streaming
incompressible huffman runlength graph
small deflate 1.8 3.7 3.6 3.3
zlib 3.3 4.1 4.0 3.9
gzip 4.4 4.2 4.3 4.2
medium deflate 4.2 4.0 3.5 4.2
zlib 3.8 4.1 4.0 4.4
gzip 4.8 4.2 4.0 4.2
large deflate 4.1 3.7 3.3 3.9
zlib 4.1 4.0 3.6 4.1
gzip 5.1 3.9 3.5 3.9
pr In Memory
incompressible huffman runlength graph
small deflate 2.0 2.7 3.6 2.2
zlib 2.8 2.9 3.8 2.3
gzip 4.1 2.8 3.3 2.3
medium deflate 1.4 3.0 2.3 2.8
zlib 3.6 3.0 2.6 3.0
gzip 5.1 3.1 3.0 3.3
large deflate 2.9 2.9 2.3 2.9
zlib 3.9 3.1 2.6 3.1
gzip 5.3 3.3 3.1 3.3
pr Streaming
incompressible huffman runlength graph
small deflate 2.2 3.3 3.3 3.1
zlib 3.8 3.7 3.8 3.8
gzip 3.9 3.6 4.4 3.8
medium deflate 3.9 3.5 3.3 3.9
zlib 3.8 3.9 3.6 4.2
gzip 4.8 3.7 3.4 4.0
large deflate 6.7 3.3 2.9 3.5
zlib 4.0 3.6 3.1 3.9
gzip 5.3 3.5 3.2 3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants