Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning off backlight on short idle disables long idle #839

Open
vorbeiei opened this issue Dec 23, 2024 · 2 comments
Open

Turning off backlight on short idle disables long idle #839

vorbeiei opened this issue Dec 23, 2024 · 2 comments
Assignees
Labels
bug Something isn't working done The underlying issue has been fixed

Comments

@vorbeiei
Copy link
Contributor

Perform all steps below and tick them with [x]

  • [x ] Check the related part of the Documentation
  • [x ] Update openHASP to the latest version
  • [ x] Reproduce the issue and describe all steps

Describe the bug

Due to the line of code if(hasp_first_touch_state) return; // don't update sleep when first touch is still active in hasp.cpp long idle can never be reached if the backlight is turned completely off with short idle already.

To Reproduce

turn off backlight in short_idle.cmd and watch it never reach long-idle

Expected behavior

I guess the question is if that is expected behaviour, but I would think not? Long idle should still be reached if screen was turned off before.(In my peticular case I turn off backlight with short idle and trigger deep sleep on long idle in custom code)

@vorbeiei vorbeiei added the bug Something isn't working label Dec 23, 2024
@fvanroie
Copy link
Collaborator

It looks like a performance enhancing early quick exit of that function. I can't say it's deliberate... that code hasn't been touched in a long time.

What happens when you comment out that code? Does it work as expected then?

@vorbeiei
Copy link
Contributor Author

When commenting it out long idle starts to work again, yes.

fvanroie pushed a commit that referenced this issue Dec 23, 2024
@fvanroie fvanroie added the done The underlying issue has been fixed label Dec 23, 2024
@fvanroie fvanroie self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done The underlying issue has been fixed
Projects
None yet
Development

No branches or pull requests

2 participants