Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to reproduce the results under (ResNet-18, DSMIL, Camelyon16) #20

Closed
wuxchcandoit opened this issue Apr 8, 2024 · 4 comments
Closed

Comments

@wuxchcandoit
Copy link

Excuse me. May I ask you a simple question?
Is the classification task for dataset TCGA-NSCLC still a binary classification task even though TCGA-NSCLC includes two subtype?

@wuxchcandoit
Copy link
Author

wuxchcandoit commented Apr 8, 2024

Besides, I failed to reproduce the results in the paper with the setting (ResNet-18 pretrained with ImageNet, DSMIL (without IBMIL), CAMELYON16) even though the public processed features in BaiduCloud (Camelyon16_ImageNet) have been used. I can only obtain about 73.xx AUC scores. What should I do to reproduce the results in the paper now? It that reasonable? Do you reproduce the same results as mine?

@wuxchcandoit wuxchcandoit changed the title Num_classes of dataset TCGA-NSCLC failed to reproduce the results under (ResNet-18, DSMIL, Camelyon16) Apr 8, 2024
@HHHedo
Copy link
Owner

HHHedo commented Apr 9, 2024

  1. The num_class for tcga is set to 2.

  2. The unstable training of dsmil is also observed by myself (see issue ) and others (see issue). One possible reason is that the attention-based aggregator failed to learn meaningful weight. You could observe these attention score during training and try different settings .

@HHHedo HHHedo closed this as completed Apr 9, 2024
@wuxchcandoit
Copy link
Author

wuxchcandoit commented Apr 9, 2024

Actually, I also failed to reproduce the results under the settings (ResNet-18 pretrained with ImageNet, TransMIL, Camelyon16). Therefore, the problem is not only about the unstable training of DSMIL. Are the public pre-computed features in BaiduCloud reliable?

@HHHedo
Copy link
Owner

HHHedo commented Apr 9, 2024

Since all the aggregators used in our paper are open-resourced, you may reproduce the baselines based on their repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants