Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate test failure of BasicAuthTest #118

Open
rzo1 opened this issue Aug 24, 2022 · 0 comments
Open

Investigate test failure of BasicAuthTest #118

rzo1 opened this issue Aug 24, 2022 · 0 comments

Comments

@rzo1
Copy link
Collaborator

rzo1 commented Aug 24, 2022

BasicAuthTest

Not sure what changed to make this test fail. The code never allowed anything more than provide credentials, but using HttpClient manually, I would use following code to define that I want authentication to be done preemptively:

		final BasicScheme basicAuth = new BasicScheme();
		basicAuth.initPreemptive(new UsernamePasswordCredentials(userName, password));

So now I'm wondering how this used to work. This might require code changes unless you know of a use case where this (still) works. I expect the test to work the same as when it was written in Spock syntax (WireMock does the real magic in both the Spock and JUnit tests).

Looks like Spock/Groovy tests were not executed for a (long) time (see #117) We should dig into the JUnit5 migrated code to understand what is going on here and how we can fix it.

@rzo1 rzo1 added this to the v5.0.0 milestone Aug 24, 2022
rzo1 added a commit to brbog/crawler4j that referenced this issue Aug 24, 2022
@rzo1 rzo1 modified the milestones: v5.0.0, v5.0.1 Aug 24, 2022
@rzo1 rzo1 modified the milestones: v5.0.1, v5.0.2 Dec 12, 2022
@rzo1 rzo1 modified the milestones: v5.0.2, v5.0.3 May 23, 2023
@rzo1 rzo1 modified the milestones: v5.0.3, v5.1.1 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant