Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Open for all] Add Header and Footer #4

Closed
Kajol-Kumari opened this issue Dec 6, 2020 · 10 comments
Closed

[Open for all] Add Header and Footer #4

Kajol-Kumari opened this issue Dec 6, 2020 · 10 comments
Assignees
Labels
frontend This issue is related to frontend good first issue Good for newcomers

Comments

@Kajol-Kumari
Copy link
Member

  • Add header and footer as reusable component so that It can just be rendered wherever required.

Dependent of issue #3 [ First This issue needs to be resolved ]

@Kajol-Kumari Kajol-Kumari added good first issue Good for newcomers frontend This issue is related to frontend labels Dec 6, 2020
@codewithvk
Copy link
Contributor

Can we use any react library? Ex. Material UI, Semantic UI

@Kajol-Kumari
Copy link
Member Author

Hey @codewithvk yes, You can use material UI

@codewithvk
Copy link
Contributor

I want to work on that. can you assign me?

@sreechand2002
Copy link
Contributor

sreechand2002 commented Dec 6, 2020

can you assign this to me

@Kajol-Kumari
Copy link
Member Author

Hey @codewithvk as this issue is dependent on #3. I request you to please finish that one. Also we can't assign more than one issue at once to anybody. So waiting for your PR for the previous one :)

Hey @sreechand2002 you can go ahead with this one one @codewithvk finishes the dependent issue. Meanwhile you can explore on its implementation, I am assigning it to you. Happy Learning :)

@codewithvk
Copy link
Contributor

@Kajol-Kumari I already Made pr for #3. You can check.

@Kajol-Kumari
Copy link
Member Author

@Kajol-Kumari I already Made pr for #3. You can check.

Ah, I saw it late. No worries more issue are coming for grab :)

@Kajol-Kumari Kajol-Kumari changed the title [Frontend] Add Header and Footer [Open for all] Add Header and Footer Dec 7, 2020
@Aaryan8751
Copy link
Contributor

Hi @Kajol-Kumari I wanna work on this.

@Kajol-Kumari
Copy link
Member Author

Hey @Aaryan8751 you can go ahead with this one. Please make sure to add the test the code and do the following:

  1. create a folder with name header_and_footer.
  2. Make a folder under this with your name and put the header and footer files in there after testing.

This is required as we would be picking up the best style and use it in our website. If you need any further clearance, pleaselet me know.

Happy Coding :)

@Aaryan8751
Copy link
Contributor

@Kajol-Kumari I have added the header and footer and have also made a pull request.
screencapture-localhost-3000-home-2020-12-08-01_52_18
Here is the screenshot of the page Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This issue is related to frontend good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants