Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare_umap_data code duplication #4

Open
alessiamarcolini opened this issue Aug 31, 2020 · 1 comment
Open

prepare_umap_data code duplication #4

alessiamarcolini opened this issue Aug 31, 2020 · 1 comment
Labels
invalid This doesn't seem right

Comments

@alessiamarcolini
Copy link
Contributor

It seems there is a private method of UmapExperiment _prepare_umap_data who does the exact same things of the function prepare_umap_data in the umap_functions module, i.e. removing NaNs columns and train/test splitting.

Why code duplication? Which is the "most correct" one?
@alessiamarcolini alessiamarcolini added the invalid This doesn't seem right label Aug 31, 2020
@lorenz-gorini
Copy link
Member

UmapExperiment Is meant to be the correct way to do things and it should replace the functions from umap_functions.
They were both kept in place during transition (we should test if they both yield the same results)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alessiamarcolini @lorenz-gorini