-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"_quirks_mode" metric is always false #186
Comments
Are there any example pages that return |
HTTPArchive/legacy.httparchive.org#40 (comment) has a query that still works with newer dataset. I ran it now on https://docs.google.com/spreadsheets/d/14-44npYPWVgdPQyMzIhdfD1m3UTEsqOSnH93rPNHbi4/edit?usp=sharing |
I think that result misses out pages that have no doctype at all. Running a query for |
No wait, there's a whole bunch of rows with |
@zcorpan can we close this? |
No, we should either fix the metric so it works again or remove it. The original implementation is here https://github.com/HTTPArchive/legacy.httparchive.org/blob/master/custom_metrics/quirks_mode.js That repo is now marked legacy. Should it be moved somewhere else? |
Here's a query that looks at all values of the custom metric: SELECT
JSON_EXTRACT(payload, '$._quirks_mode') AS q,
COUNT(0) AS n
FROM
`httparchive.pages.2020_06_01_mobile`
GROUP BY
q
For some reason the JSON encoding of |
Ooh, so it is working then. Great! Thanks @rviscomi |
So per this metric, ~4.17% of pages are in quirks mode. |
In HTTPArchive/legacy.httparchive.org#58 we introduced a custom metric to record
document.compatMode
. I think it has been working in the past, but now it appears to befalse
for all pages.Lots of results.
No results.
I wanted this metric now to research whatwg/quirks#48 😐
The text was updated successfully, but these errors were encountered: