Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waiver webhook failed when user record exists without role #365

Open
taesungh opened this issue Jan 26, 2024 · 0 comments
Open

Waiver webhook failed when user record exists without role #365

taesungh opened this issue Jan 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@taesungh
Copy link
Member

We had a few instances of the waiver webhook endpoint returning status 400 because some volunteers/mentors/judges had previously logged into the site but did not apply so did not have a role attribute causing the validation for UserRecord to fail. We could maybe add a "guest" role to all users when logging in, but in practice, non-hackers would have been added to the database before signing the waiver, so this is not a huge issue. We should at least properly handle ValidationError instead of letting that surface.

@taesungh taesungh added the bug Something isn't working label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant