Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require build to succeed before preview deployment #207

Open
taesungh opened this issue Nov 1, 2024 · 0 comments
Open

Require build to succeed before preview deployment #207

taesungh opened this issue Nov 1, 2024 · 0 comments

Comments

@taesungh
Copy link
Member

taesungh commented Nov 1, 2024

Stemming from #205 and related to #206, to further reduce the number of deployments on Vercel, we can modify our Actions workflow to run the preview deployment for pull requests only if next build runs successfully. This will mean it takes a little longer for a successful preview deployment to be available but will help reduce the amount of unnecessary failed deployments which go into our daily quota of 100. This should also help tech team developers be more aware of what went wrong during a deployment since the build logs in Vercel account aren't accessible to everyone, but the Actions workflow logs should be.

Regarding the build time, we might be able to take advantage of Vercel's remote cache as they describe a way to Use Remote Caching from external CI/CD. If this works out, I think the build artifacts from the Actions workflow can be restored from cache during the preview deployment, hopefully making the time increase negligible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant