Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend: Fix bug in adding favorites on product page #291

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Frontend: Fix bug in adding favorites on product page #291

wants to merge 2 commits into from

Conversation

jaimakena
Copy link
Collaborator

@jaimakena jaimakena commented Dec 13, 2021 •
edited by BikramRawat
Loading

Description

Please provide a short summary explaining what this PR is about.

Fixes

#271

How to test?

Please provide a short summary how your changes can be tested?

Checklist

  • I have performed a self-review of my own code
  • I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
  • I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
  • I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
  • This PR is ready to be merged and not breaking any other functionality

@jaimakena jaimakena requested a review from a team as a code owner December 13, 2021 21:00
@chklueter chklueter temporarily deployed to webshop-clas-feature-fa-ugcrl7 December 13, 2021 21:00 Inactive
@jaimakena jaimakena changed the title Changes to fix issue with favourites #271 Changes to fix issue 271 with favourites Dec 13, 2021
@jaimakena jaimakena linked an issue Dec 13, 2021 that may be closed by this pull request
Bug: on Product page adding to favourites not working correctlly #271
Open
@BikramRawat BikramRawat added bug Something isn't working Frontend labels Dec 13, 2021
@BikramRawat BikramRawat added this to the Milestone 3 - Purchase milestone Dec 13, 2021
BikramRawat
BikramRawat reviewed Dec 13, 2021
View reviewed changes
Copy link
Collaborator

@BikramRawat BikramRawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the eslint error, check the comment. Otherwise its working fine 👍

src/client/containers/ProductPage/ProductPage.Container.js Outdated Show resolved Hide resolved
simonreddy2001
simonreddy2001 requested changes Dec 14, 2021
View reviewed changes
Copy link
Collaborator

@simonreddy2001 simonreddy2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add refresh.. it wont remove when you remove a product

src/client/components/ProductDetails/ProductDetails.component.js Show resolved Hide resolved
@chklueter chklueter temporarily deployed to webshop-clas-feature-fa-8rwby9 December 14, 2021 20:12 Inactive
BikramRawat
BikramRawat approved these changes Dec 14, 2021
View reviewed changes
Copy link
Collaborator

@BikramRawat BikramRawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Working fine

dpfernandes
dpfernandes requested changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@dpfernandes dpfernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An Issue number is not a title for a PR - Please change the title of the PR.

@GreeshmaRahool GreeshmaRahool changed the title Changes to fix issue 271 with favourites Frontend: Fix bug in adding favorites on product page Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonreddy2001 simonreddy2001 simonreddy2001 requested changes

@dpfernandes dpfernandes dpfernandes requested changes

@BikramRawat BikramRawat BikramRawat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Frontend
Projects
None yet
Milestone
Milestone 3 - Purchase
Development

Successfully merging this pull request may close these issues.

Bug: on Product page adding to favourites not working correctlly
5 participants
@jaimakena @dpfernandes @simonreddy2001 @BikramRawat @chklueter