Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use initialize_copy instead of Marshal to get a deep clone of the Arel AST #97

Open
mvgijssel opened this issue Jul 9, 2019 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@mvgijssel
Copy link
Collaborator

Currently

Marshal.load(Marshal.dump(object))

is used to get a deep clone of an Arel AST which is necessary when modifying the tree. Using Marshal feel like a hack to get a deep clone, Ruby's initialize_copy feels like a better solution to this problem.

To achieve this all Arel nodes need to implement initialize_copy when their instance variables contain a complex object, a non scalar like String or Integer.

@mvgijssel mvgijssel added the enhancement New feature or request label Jul 9, 2019
@mvgijssel mvgijssel added this to the 1.0.0 milestone Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant