Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Move MAX_SID_LENGTH into the public API #2650

Open
Chardrazle opened this issue Feb 7, 2023 · 0 comments · May be fixed by #3103
Open

[FR] Move MAX_SID_LENGTH into the public API #2650

Chardrazle opened this issue Feb 7, 2023 · 0 comments · May be fixed by #3103
Labels
[API] Area: Changes in SRT library API Type: Enhancement Indicates new feature requests
Milestone
v1.6.0

Comments

@Chardrazle
Copy link

Not a problem, per se, just a case of avoiding a magic number (512) in the code.
The constant is currently sitting in socketconfig.h.
Related to the access control behaviour.
@Chardrazle Chardrazle added the Type: Enhancement Indicates new feature requests label Feb 7, 2023
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Feb 10, 2023
@maxsharabayko maxsharabayko added the [API] Area: Changes in SRT library API label Feb 10, 2023
@maxsharabayko maxsharabayko modified the milestones: v1.5.4, v1.6.0 Jun 12, 2024
@ethouris ethouris linked a pull request Jan 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[API] Area: Changes in SRT library API Type: Enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

[API] Set up length limits for STREAMID and PACKETFILTER in the API ethouris/srt
2 participants
@Chardrazle @maxsharabayko