fix: make tx.from optional and improve BigInt parsing in transaction handling

Author: AryanGodara

apps/iframe/src/requests/utils/boop.ts

@@ -187,15 +187,16 @@ function safeParseSignature(validatorData?: Hex) {
 }
 
 export async function boopFromTransaction(account: Address, tx: ValidRpcTransactionRequest): Promise<Boop> {
-    // TODO bigint casts need validation
-
     return {
-        account: tx.from ?? account, // Use provided account if tx.from is not available
+        account: tx.from ?? account,
         dest: tx.to,
         payer: zeroAddress, // happyPaymaster, // TODO need to fund paymaster
-        value: tx.value ? BigInt(tx.value) : 0n,
+        value: tx.value !== undefined ? (parseBigInt(tx.value) ?? 0n) : 0n,
         nonceTrack: 0n,
-        nonceValue: tx.nonce ? BigInt(tx.nonce) : await getNextNonce(account),
+        nonceValue:
+            tx.nonce !== undefined
+                ? (parseBigInt(tx.nonce) ?? (await getNextNonce(account)))
+                : await getNextNonce(account),
         callData: tx.data ?? "0x",
         validatorData: "0x", // we will fill after signing
         extraData: createValidatorExtraData(account, tx.to),

apps/iframe/src/requests/utils/checks.ts

@@ -28,20 +28,21 @@ export function checkAuthenticated() {
 /**
  * Type of valid tx requests, use {@link checkedTx} to verify.
  */
-export type ValidRpcTransactionRequest = RpcTransactionRequest & { from: Address; to: Address }
+export type ValidRpcTransactionRequest = RpcTransactionRequest & { to: Address }
 
 /**
  * Asserts that the transaction has its destination defined, throws a {@link EIP1474InvalidInput}.
  * @throws EIP1474InvalidInput if the transaction is malformatted
  */
 export function checkedTx(tx: RpcTransactionRequest): ValidRpcTransactionRequest {
+    // Check required fields
     if (!tx.to) /****/ throw new EIP1474InvalidInput("missing 'to' field in transaction parameters")
-    if (!tx.from) /**/ throw new EIP1474InvalidInput("missing 'from' field in transaction parameters")
 
+    // Validate addresses
     if (!isAddress(tx.to)) /****/ throw new EIP1474InvalidInput(`not an address: ${tx.to}`)
-    if (!isAddress(tx.from)) /**/ throw new EIP1474InvalidInput(`not an address: ${tx.from}`)
+    if (tx.from !== undefined && !isAddress(tx.from)) /**/ throw new EIP1474InvalidInput(`not an address: ${tx.from}`)
 
-    // Check if value exists and can be parsed as BigInt (allows zero values)
+    // Check if the value and nonce exist, and can be parsed as BigInt (allows zero values)
     if (tx.value !== undefined && parseBigInt(tx.value) === undefined)
         throw new EIP1474InvalidInput(`value is not a number: ${tx.value}`)
     if (tx.nonce !== undefined && parseBigInt(tx.nonce) === undefined)