Skip to content

Commit 0e51d32

Browse files
committed
update comment
1 parent 8157975 commit 0e51d32

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

apps/submitter/lib/services/BlockService.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -263,14 +263,11 @@ export class BlockService {
263263
this.#handleNewBlock(newBlock)
264264
}
265265

266-
// TODO Verify and update this comment to account for the fact we don't rely on the Viem nonce manager anymore,
267-
// but on our own.
268-
269-
// Note that in the case of re-orgs, we will be missing blocks compared to the "most re-orged"
270-
// block that we saw. We should handle that but don't sweat too much about it right now. We
271-
// haven't really audited the code for re-orgs. In theory, the Viem nonce manager should handle
272-
// EVM tx nonces. Boop nonces get a resync via `InvalidNonce`, and the nonce cache expires fast
273-
// anyway. We might suffer from stuck transactions in the future (meant for pre-re-org chain).
266+
// Note that in the case of re-orgs, we might be missing blocks compared to the "most re-orged" block that we saw.
267+
// We should handle that but don't sweat too much about it right now. We haven't really audited the code for
268+
// re-orgs. Our nonce manager should handle EVM tx nonces. Boop nonces get a resync via `InvalidNonce`, and the
269+
// nonce cache expires fast anyway. We might suffer from stuck transactions in the future (meant for pre-re-org
270+
// chain).
274271
//
275272
// The most immediate to-do item is to call out the resync system to cancel submit and
276273
// createAccount transactions, which we need for robustness.

0 commit comments

Comments
 (0)