Add more brass ammo calibers#1010
Open
Iisazel wants to merge 4 commits intoHardLightSector:masterfrom
Open
Conversation
github-actions
bot
added
S: Untriaged
No C#
FTL
YML
size/L
and removed
S: Untriaged
labels
Added 'deleteOnSpawn' property to various cartridge ammo components.
Contributor
|
If you could add 12 gauge and 4 gauge high-power versions. That'd be rad as hell! Tryo's already given the go-ahead on it too. And don't gota go crazy. Buckshot at minimum is perfectly reasonable. But if you want to do a few other round-type's. Be my guest :3 |
Collaborator
|
juuuust make sure is still caseless (it should be) |
Author
|
Yep, tested them. Works perfectly fine, cartriges delete on spawn properly |
Author
I can do that, but after this pull gets merged |
Contributor
Yeppie!!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Added more craftable brass ammo calibers, specifically 45 ACP, 46x30, 45 magnum, 556x45, 57x28, 762x39, 762x51, 762x54 and 8x65 SKR
Why / Balance
Because fenn said i could, so i did! Followed same balance - high-power is 50% stronger (Rounded down), flechette is 50% weaker (Also rounded down because why not). Bigger calibers require more time to make - 762x39 and 762x51 takes 10 seconds, while 45 magnum, 762x54 and 8x65 take 15 seconds per bullet to craft
Technical details
Literally copy-pasted what Trylo did with 9x19mm 9 more times everywhere
How to test
Emag protolathe/get ammofab, print things, craft bullets, shoot deathsquad with flechettes
Media
Breaking changes
Changelog
🆑