Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other players should be able to join a room even if one player is left #5

Open
shravan-balasubramanian opened this issue Oct 20, 2019 · 5 comments

Comments

@shravan-balasubramanian
Copy link
Contributor

In a multiplayer game, the room becomes invalid if anyone player leaves. This shouldn't be the case. The game should be terminated and the one who is playing should wait until any other player joins and the room should be valid to join. Right now it's invalid if one of the player leaves

@HarishTeens
Copy link
Owner

The one who didn't leave should be terminated or should he wait ?
Right now even if one of the players leaves the room they can join the same room with that Room ID.

@shravan-balasubramanian
Copy link
Contributor Author

It doesn't work that way for me. If any of the two players leave, the room becomes invalid for any others to join :(

@HarishTeens
Copy link
Owner

Sorry again , In some build I did it, should have gone somewhere 😅 , if you are interested you might work on this as well :)

@shravan-balasubramanian
Copy link
Contributor Author

I will take this in 3-4 days :)

@shravan-balasubramanian
Copy link
Contributor Author

shravan-balasubramanian commented Oct 29, 2019

Am sorry. This works. Still, a few bugs are there. I will edit the issue and work on the same

  1. Name is not displayed in the chatbox
  2. On user giving cancel, he/she has to be prompted that others can join the game room

Screenshot 2019-10-29 at 5 22 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants