fix: remove rocksdb.cur-size-all-mem-tables from tests, because it apparently behaves differently in different environments

Author: luislhl

rocksdb/tests/test_db.py

@@ -742,17 +742,9 @@ def test_flush(self):
         self.db.put(b"a", b"1")
         self.db.put(b"b", b"2")
 
-        # Verify data is in memtable (memtable size > 0)
-        memtable_size_before = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables'))
-        self.assertGreater(memtable_size_before, 0)
-
         # Flush with default parameters (all column families, wait=True)
         self.db.flush()
 
-        # Verify memtable size decreased after flush
-        memtable_size_after = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables'))
-        self.assertLess(memtable_size_after, memtable_size_before)
-
         # Verify flush created SST files at level 0
         final_l0_files = int(self.db.get_property(b'rocksdb.num-files-at-level0'))
         self.assertGreater(final_l0_files, initial_l0_files)
@@ -775,25 +767,9 @@ def test_flush_all_column_families(self):
         self.db.put((self.cf_a, b"a_key"), b"a_value")
         self.db.put((self.cf_b, b"b_key"), b"b_value")
 
-        # Check memtable sizes before flush
-        memtable_default_before = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables'))
-        memtable_cf_a_before = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables', self.cf_a))
-        memtable_cf_b_before = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables', self.cf_b))
-        self.assertGreater(memtable_default_before, 0)
-        self.assertGreater(memtable_cf_a_before, 0)
-        self.assertGreater(memtable_cf_b_before, 0)
-
         # Flush all column families (default behavior)
         self.db.flush()
 
-        # Verify memtable sizes decreased after flush
-        memtable_default_after = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables'))
-        memtable_cf_a_after = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables', self.cf_a))
-        memtable_cf_b_after = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables', self.cf_b))
-        self.assertLess(memtable_default_after, memtable_default_before)
-        self.assertLess(memtable_cf_a_after, memtable_cf_a_before)
-        self.assertLess(memtable_cf_b_after, memtable_cf_b_before)
-
         # Verify all column families were flushed (SST files created)
         final_default_l0 = int(self.db.get_property(b'rocksdb.num-files-at-level0'))
         final_cf_a_l0 = int(self.db.get_property(b'rocksdb.num-files-at-level0', self.cf_a))
@@ -812,21 +788,9 @@ def test_flush_single_column_family(self):
         self.db.put((self.cf_a, b"a_key"), b"a_value")
         self.db.put((self.cf_b, b"b_key"), b"b_value")
 
-        # Check memtable sizes before flush
-        memtable_cf_a_before = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables', self.cf_a))
-        memtable_cf_b_before = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables', self.cf_b))
-        self.assertGreater(memtable_cf_a_before, 0)
-        self.assertGreater(memtable_cf_b_before, 0)
-
         # Flush only cf_a
         self.db.flush(column_families=self.cf_a)
 
-        # Verify memtable size decreased for cf_a but not for cf_b
-        memtable_cf_a_after = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables', self.cf_a))
-        memtable_cf_b_after = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables', self.cf_b))
-        self.assertLess(memtable_cf_a_after, memtable_cf_a_before)
-        self.assertEqual(memtable_cf_b_after, memtable_cf_b_before)  # cf_b memtable unchanged
-
         # Verify only cf_a was flushed (SST files created)
         final_cf_a_l0 = int(self.db.get_property(b'rocksdb.num-files-at-level0', self.cf_a))
         final_cf_b_l0 = int(self.db.get_property(b'rocksdb.num-files-at-level0', self.cf_b))
@@ -843,20 +807,15 @@ def test_flush_multiple_column_families(self):
         self.db.put((self.cf_a, b"a_key"), b"a_value")
         self.db.put((self.cf_b, b"b_key"), b"b_value")
 
-        # Check memtable sizes before flush
-        memtable_cf_a_before = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables', self.cf_a))
-        memtable_cf_b_before = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables', self.cf_b))
-        self.assertGreater(memtable_cf_a_before, 0)
-        self.assertGreater(memtable_cf_b_before, 0)
-
         # Flush both cf_a and cf_b
         self.db.flush(column_families=[self.cf_a, self.cf_b])
 
-        # Verify memtable sizes decreased for both
-        memtable_cf_a_after = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables', self.cf_a))
-        memtable_cf_b_after = int(self.db.get_property(b'rocksdb.cur-size-all-mem-tables', self.cf_b))
-        self.assertLess(memtable_cf_a_after, memtable_cf_a_before)
-        self.assertLess(memtable_cf_b_after, memtable_cf_b_before)
+        # Verify both were flushed (SST files created)
+        final_cf_a_l0 = int(self.db.get_property(b'rocksdb.num-files-at-level0', self.cf_a))
+        final_cf_b_l0 = int(self.db.get_property(b'rocksdb.num-files-at-level0', self.cf_b))
+
+        self.assertGreater(final_cf_a_l0, initial_cf_a_l0)
+        self.assertGreater(final_cf_b_l0, initial_cf_b_l0)
 
         # Verify both were flushed (SST files created)
         final_cf_a_l0 = int(self.db.get_property(b'rocksdb.num-files-at-level0', self.cf_a))