Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hl] unify stack traces with other targets #10926

Closed
kLabz opened this issue Jan 12, 2023 · 2 comments · Fixed by #11249
Closed

[hl] unify stack traces with other targets #10926

kLabz opened this issue Jan 12, 2023 · 2 comments · Fixed by #11249
Assignees
Milestone

Comments

@kLabz
Copy link
Contributor

kLabz commented Jan 12, 2023

Since a40ab79, hl has derived from other targets for stack trace handling, which led to CI failing.

I'm adding a patch to make CI green again, but we need a proper solution.

@Apprentice-Alchemist
Copy link
Contributor

For context, the root cause of the issue is the exception stack handling rework in 98df217

a40ab79 just reverted the fix I implemented in #10610.
(Before that PR hl-ver was 1.11 for the test-suite and the old behaviour was used, so the issue didn't arise)

@Simn Simn added this to the Release 4.3 milestone Mar 24, 2023
@kLabz
Copy link
Contributor Author

kLabz commented Mar 31, 2023

@ncannasse any thoughts on that? I don't know what to do about it, it seems wrong to me that hl derived from the common behavior but I suppose simply reverting that commit would break things for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants