New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect.field(String, "fromCharCode") doesnt work #1103

Open

NeeEoo opened this issue Apr 25, 2024 · 0 comments · May be fixed by #1104

NeeEoo commented Apr 25, 2024

https://github.com/HaxeFoundation/hxcpp/blob/master/src/String.cpp#L2176
Hxcpp implementation of String is missing this

bool String::__GetStatic(const ::String &inName, Dynamic &outValue, ::hx::PropertyAccess inCallProp)
{
	if (HX_FIELD_EQ(inName,"fromCharCode") ) { outValue = fromCharCode_dyn(); return true; }
	return false;
}

which causes String.fromCharCode to not work on reflection.

NeeEoo linked a pull request

that will close this issue

Fixed String.fromCharCode when using reflection #1104

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment