Skip to content
This repository has been archived by the owner on Jan 14, 2019. It is now read-only.

Add a MR status badge #129

Open
nclsHart opened this issue Sep 10, 2017 · 3 comments
Open

Add a MR status badge #129

nclsHart opened this issue Sep 10, 2017 · 3 comments

Comments

@nclsHart
Copy link
Contributor

Since latest versions of GitLab, the API now returns the MR status. For example:

...
  "merge_when_pipeline_succeeds": true,
  "merge_status": "can_be_merged",
  "subscribed" : true,
...

source: https://docs.gitlab.com/ee/api/merge_requests.html#list-merge-requests

merge_status possible values are: can_be_merged, cannot_be_merged and unchecked.

We could use this new information to create a new column "status" with a badge.

Possible rendering of the new feature:

can_be_merged
cannot_be_merged
unchecked

Depending of the projet/team workflow validation, this feature could give duplicate results with the CI badge.

@notFloran
Copy link
Contributor

Do you know if cannot_be_merged cover the failure of the CI?

We could use this new information to create a new column "status" with a badge.

I'm not a fan of the new column, maybe we can mix the CI column and this new data in one column "Status".

@nclsHart
Copy link
Contributor Author

Do you know if cannot_be_merged cover the failure of the CI?

I hope so, but I need to check it. It's not really specify in the GitLab API documentation.

@notFloran
Copy link
Contributor

what cannot_be_merged means is, essentially, whether the MR has merge conflicts. But that's not the only reason we might be unable to merge an MR.

We need to mix the CI status and the "cannot be merged" in some way

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants