Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doublecheck that the turing warning "link" doesn't affect results or performance #117

Closed
jlperla opened this issue Aug 16, 2022 · 0 comments

Comments

@jlperla
Copy link
Member

jlperla commented Aug 16, 2022

See TuringLang/DynamicPPL.jl#422

The question is whether the

┌ Warning: [DynamicPPL] attempt to link a linked vi
└ @ DynamicPPL C:\Users\jesse\.julia\packages\DynamicPPL\1qg3U\src\varinfo.jl:821

warnings actually matter. We should:

  • Make sure we can replicate that issue happing with rbc_joint_1 or something like that. If not, we can revisit the strategy.
  • Witth the current main branch do an estimate of rbc_joint_1 and rbc_kalman_1 with the burnin initial conditions we saved, for 1000 draws or something like that
  • With the latest ssgu branch, do an ]instantiat and then redo the experiments. If the estimates and the ESS/s are roughly comparable then that is good enough. Confirm that there is at least one of those warnings popping up.
@jlperla jlperla closed this as completed Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant