Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See if a specialized trainer supporting pre_fit for cli/etc. is feasible #21

Open
jlperla opened this issue Nov 15, 2021 · 0 comments
Open

Comments

@jlperla
Copy link
Member

jlperla commented Nov 15, 2021

From mauricio on slack:

Just in case you find it useful I give a different idea which I would probably take if doing something like this. Note that LightningCLI can receive as input the trainer_class. The reason for this is for users to be able to extend the lightning trainer class when needed. A possibility could be to extend the fit method such that internally it would do some pretraining (disabling callbacks and loggers) and then call super().fit(). Another possibility would be to have a new method e.g. pre_fit which would implement this. Then the user would call first pre_fit and then fit. The reason why I would tend to go this way is that this fits more as training logic than cli logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant