-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Configured picker treats empty provider headers as configured #4333
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workingrelease-blockerMust be fixed before the next releaseMust be fixed before the next releasereliabilityReliability, flaky behavior, retries, fallbacks, and robustnessReliability, flaky behavior, retries, fallbacks, and robustnesstuiTerminal UI behavior, rendering, or interactionTerminal UI behavior, rendering, or interactionv0.8.68Targeting v0.8.68Targeting v0.8.68
Milestone
Description
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingrelease-blockerMust be fixed before the next releaseMust be fixed before the next releasereliabilityReliability, flaky behavior, retries, fallbacks, and robustnessReliability, flaky behavior, retries, fallbacks, and robustnesstuiTerminal UI behavior, rendering, or interactionTerminal UI behavior, rendering, or interactionv0.8.68Targeting v0.8.68Targeting v0.8.68
Projects
StatusShow more project fields
Done
Problem
The TUI's Model · configured view can treat an unconfigured provider as configured when the persisted provider entry contains only an empty table such as:
provider_config_is_explicitpreviously tested whetherhttp_headerswas present, not whether it contained a meaningful nonblank entry. Empty/default provider fields could also survive serialization. A config polluted with these empty tables therefore expanded the configured picker to hundreds of global catalog rows.This is distinct from the broader provider/catalog refactor in #3949.
Expected behavior
Evidence and implementation
Draft PR #4332 adds the semantic predicate, empty-structure serialization guards, existing polluted-config compatibility, and focused config/provider/picker tests. Local full TUI verification: 6,378 passed, 0 failed, 2 ignored; config crate: 368 passed, 0 failed.
Acceptance
Do not close until the landed build is verified against a real previously polluted user config.