Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IValidatableObject instead of homebrew "IsValid" method #33

Open
hf-kklein opened this issue May 27, 2020 · 0 comments
Open

Implement IValidatableObject instead of homebrew "IsValid" method #33

hf-kklein opened this issue May 27, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hf-kklein
Copy link
Collaborator

BO4E-dotnet/BO4E-dotnet/BO/BusinessObject.cs

Line 450 in 33a3dd8

public virtual bool IsValid()

The current implementation of IsValid simply tries to serialize the respective BusinessObject or COMponent. While this is inherently consistent with the Newtonsoft.Json attributes there is a more .NET-Standard way to do it: By implementing IValidatableObject
@hf-kklein hf-kklein added enhancement New feature or request good first issue Good for newcomers labels May 27, 2020
@hf-kklein hf-kklein mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hf-kklein