Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Emails not via Github Commit Message but from Python #12

Open
4 tasks
hf-kklein opened this issue Mar 1, 2021 · 0 comments
Open
4 tasks

Send Emails not via Github Commit Message but from Python #12

hf-kklein opened this issue Mar 1, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@hf-kklein
Copy link
Contributor

As of now we're only forwarding the git commit messages to recipients in the Settings→Notifications Tab. This is a very basic kind of notification and right now we're also relying on konstantin to pre-screen the git messages to not forward each and every commit on any branch (including development commits) to the abo recipients.

It'd be great if could send emails from the Python script. This would allow us to formulate sentences or put context around plain "renamed without modification" git messages. I'm thinking of something like this...
We could split this in multiple steps:

  • create small natural language sentences from the overall metadata changes that could be the content of the email
  • Get an email sending address (SMTP credentials) from Patrice
  • send emails to [email protected]. So we do not need any overhead for user and recipient management. This is still patrice job.
  • We could store the credentials in an azure key vault or simply in environment variables.

The only code I know that sends emails is the one in the notificationService that never made it to production.

@hf-kklein hf-kklein added the enhancement New feature or request label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants