Incompatibility with General Improvements

[arookas]

Playing this mod with General Improvements makes it so that the ship internal camera becomes a blank monitor (UseBetterMonitors = true). It appears to be because of the following code:

Material[] materialArray = new Material[9];
materialArray[0] = MonitorWallMeshRenderer.materials[0];
materialArray[1] = MonitorWallMeshRenderer.materials[1];
materialArray[2] = MonitorWallMeshRenderer.materials[1];
materialArray[3] = MonitorWallMeshRenderer.materials[1];
materialArray[4] = MonitorWallMeshRenderer.materials[1];
materialArray[5] = MonitorWallMeshRenderer.materials[1];
materialArray[6] = MonitorWallMeshRenderer.materials[1];
materialArray[7] = MonitorWallMeshRenderer.materials[1];
materialArray[8] = MonitorWallMeshRenderer.materials[2];
MonitorWallMeshRenderer.materials = materialArray;

General Improvements relies on materials[2] being the internal ship camera. Would it be possible to add a compatibility setting for this mod?

[HolographicWings]

will do, thanks for report

[HolographicWings]

done, let me know if that work

[arookas]

Thanks for the rapid response! Unfortunately it doesn't seem to fixing this issue. It might not be this code after all. This is my current mod list:

This is UseBetterMonitors ON in GeneralImprovements without LethalExpansion:

And this is the same setup, only with LethalExpansion enabled:

For the internal ship camera, GeneralImprovements does the following to access the internal ship material:

case MonitorNames.InternalCam:
    targetMat = _oldMonitorsObject.GetComponent<MeshRenderer>().materials[2];
    break;

I'm not sure what else the issue could be. Do you think the issue might be better off resolved on GeneralImprovement's side?

[HolographicWings]

Did you enabled the compatibility patch I added? It's a setting in the mod setting menu

And oh.. the main camera monitor
But LE don't interact with it Oo
It only interact with the 8-screen one

[arookas]

Yea, I tried the latest update with the compatibility setting enabled and still saw the issue. I'm reaching out on the GeneralImprovements thread to have them look into it. Thanks for the help!

[arookas]

Hi! The issue has been patched in the latest GeneralImprovements update. Feel free to remove the compatibility setting as it's no longer needed. Thanks again!

[HolographicWings]

Hi! The issue has been patched in the latest GeneralImprovements update. Feel free to remove the compatibility setting as it's no longer needed. Thanks again!

Hello
Thanks for the answer
I will read the commit to understand what was the issue