Repository navigation
Commit 92e6ff3
authored
Accept only full-accuracy AL stages as converged (#99)
The KKT residual of `_abslog2_auglag` measures constraint violation,
not how well a stage minimized its objective, so a stage solved at the
loosest LSQR tolerance could be reported converged while its products
were not covariant under a change of units (0.7% on Bai/bwm2000).
`converged` now requires the accepting stage's last solve at the
full-accuracy tolerance; an inexact stage that meets the test is
followed by a stage at the floor tolerance.
Within a stage, a full step that leaves the active pattern unchanged
drops the tolerance to the floor, since the solve error is then the
only remaining error; a fixed inexact tolerance dithers at its noise
floor instead (40 solves on bwm2000, now 4).
Iteration counts on sparse lognormal matrices at n = 31623 are within
5% of the previous ones. Adds a covariance test on the Brusselator
Jacobian (Bai/bwm200) under power-of-two row scaling.
Assisted-by: Claude Fable 5.1 <noreply@anthropic.com>1 parent 87395a7 commit 92e6ff3
2 files changed
Lines changed: 41 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1300 | 1300 | | |
1301 | 1301 | | |
1302 | 1302 | | |
1303 | | - | |
1304 | | - | |
1305 | | - | |
1306 | | - | |
| 1303 | + | |
| 1304 | + | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
| 1309 | + | |
| 1310 | + | |
1307 | 1311 | | |
1308 | 1312 | | |
1309 | 1313 | | |
| |||
1852 | 1856 | | |
1853 | 1857 | | |
1854 | 1858 | | |
| 1859 | + | |
1855 | 1860 | | |
1856 | 1861 | | |
1857 | 1862 | | |
| |||
1879 | 1884 | | |
1880 | 1885 | | |
1881 | 1886 | | |
| 1887 | + | |
| 1888 | + | |
1882 | 1889 | | |
1883 | 1890 | | |
1884 | 1891 | | |
| |||
1888 | 1895 | | |
1889 | 1896 | | |
1890 | 1897 | | |
| 1898 | + | |
1891 | 1899 | | |
1892 | 1900 | | |
1893 | 1901 | | |
1894 | 1902 | | |
1895 | 1903 | | |
1896 | 1904 | | |
1897 | | - | |
| 1905 | + | |
| 1906 | + | |
| 1907 | + | |
| 1908 | + | |
| 1909 | + | |
1898 | 1910 | | |
1899 | 1911 | | |
1900 | 1912 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
31 | 42 | | |
32 | 43 | | |
33 | 44 | | |
| |||
124 | 135 | | |
125 | 136 | | |
126 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
127 | 151 | | |
128 | 152 | | |
129 | 153 | | |
| |||
0 commit comments