Load installed formulae from kegs #20897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
Oct 17, 2025
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
For now, I'm thinking I'll just do HOMEBREW_USE_INTERNAL_API, but let me know if a separate one is preferred.
This makes the most sense to me 👍🏻
Rylan12
force-pushed
the
load-installed-formulae-from-kegs
branch
from
cbd4d8b to
8861d19
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Implements loading installed formulae directly from their kegs (and install receipts) when HOMEBREW_USE_INTERNAL_API (use_internal_api?) is enabled.
- Adds conditional logic to prefer FromKegLoader when resolving formula paths.
- Adjusts FromKegLoader.try_new to use canonical formula names and include tap metadata.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final part extracted from #20830
This PR actually makes the fundamental change to
Formulary::resolveto attempt to load formulae from their kegs (and therefore, their install receipts).I've marked this as a draft for now, because I want to gate this with an environment variable. For now, I'm thinking I'll just do
HOMEBREW_USE_INTERNAL_API, but let me know if a separate one is preferred.